He was born in Cairo. Since his graduation from the Higher Cinema Institute in 1964, he worked as a tutor and then a Professor of Drama and Film Making and supervised number of undergraduate projects for almost forty two years. He worked as a Consultant for the Specialized Channels at the Egyptian Radio & Television Union since its establishment till the beginning of the broadcast. His first film Sawar Mamnora (Forbidden Photos, 1969) was one part in a trilogy and participated in Carlo Vivary Film Festival. His directorial debut long feature film was Imra’a men el Kahra (Woman from Cairo, 1971) and also participated in Carlo Vivary Film Festival. He then moved to directing comic feature films and Fi El Safe lazem nihab (In summer we must fall in love, 1972) was his first critical and public acclaim, participating in Tehran Film Festival in 1973. Followed by Daqqat Qullab (Heart Beat), Allam Eyal Eyal (World of Kids). His big hit Intabewho Aywhah El Sada (Beware Gentlemen, 1979) was selected among best hundred feature film produced by the Egyptian Cinema. His filmography includes: Rihla El Saqa’ we el Hubb (Journey of Pain and Love), Manzil el Al A’ila El Masmouma (House of the poisonous family), We Lakan Sha’an Ma Yabqa (But there something Left), and El Hukm Akher El Gilsa (Secret Session). His works include 67 feature films most of them participated in worldwide film international festivals such as Cannes, Sorrento, Carlo Vivary, Montreal and Tehran as well as twenty T.V serials and three plays.

• He won Cinema Critics & Screenwriters Association award in 1975 for Daqqat Qulla.
• He received special award in Istanbul Film Festival in 1976 for Allam Iyal Iyal.
• The First State Award for best film Director for year 1981 went to his film Intabewho Aywha El Sada.
• He had been honoured in the 23rd Cairo Film Festival for his pioneering work in the Egyptian comic feature films.